Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc fixes #491

Merged
merged 7 commits into from
Apr 17, 2017
Merged

Misc fixes #491

merged 7 commits into from
Apr 17, 2017

Conversation

Rich-Harris
Copy link
Member

Odds and ends that follow #490

@Rich-Harris
Copy link
Member Author

Right, think I'm done for now — should be uncontroversial so I'll merge this in. Summary:

  • Yield blocks were being created for components without children — fixed
  • Each block indices don't count as dependencies
  • CodeBuilder conditional blocks weren't being separated from each other
  • Text nodes either side of comments are collapsed into one, and comments at the start/end of a template don't result in surplus whitespace nodes
  • Block now has an alias method, so variables like i can be reused
  • If blocks without else blocks are now written more simply, without the get_block helper

@Rich-Harris Rich-Harris merged commit ffe040a into master Apr 17, 2017
@Rich-Harris Rich-Harris deleted the misc-fixes branch April 17, 2017 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Rich-Harris