Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typescript def for transitions #5625

Merged

Conversation

tanhauhau
Copy link
Member

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@benmccann
Copy link
Member

@tanhauhau it looks like this one will need to be rebased

@dummdidumm you might be interested in taking a look at this one

@tanhauhau tanhauhau force-pushed the tanhauhau/add-typescript-transition branch from ec6d591 to 47e5cbb Compare December 30, 2020 07:42
@pngwn pngwn added runtime Changes relating to runtime APIs and removed feature: typescript labels Jun 26, 2021
@dummdidumm dummdidumm merged commit 5d82496 into sveltejs:master Jun 27, 2021
@magentaqin magentaqin mentioned this pull request May 14, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime Changes relating to runtime APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants