Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Regression on contenteditable #6853

Conversation

RaiVaibhav
Copy link
Contributor

Fixes: #5018
Fixes: #5931

The issue caused because of setting the updated value to the data property of mustache text node, use innerText if parent have contenteditable attribute

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

Fixes: sveltejs#5018
Fixes: sveltejs#5931

Issue caused because of setting the updated value to
the data property of moustache text node, use innerText if
parent have contenteditable attribute
@RaiVaibhav
Copy link
Contributor Author

RaiVaibhav commented Oct 18, 2021

Closing: innerText is a trick that can cause another issue like dom update on text node value change, rather we should add a warning so that developers know that mustache is a text node in case of contenteditable and innerText will not even work in first place.

@RaiVaibhav RaiVaibhav closed this Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant