don't throw error if component is destroyed twice #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't there a deeper issue here that a component shouldn't be getting destroyed twice? |
|
This is for when the user destroys the component twice, not Svelte itself. Specifically, in the Definitely a case of user error (in this case, the user was me), and you could argue that Svelte shouldn't go out of its way like that. My main reason was that if I can make that mistake, anyone can... it's not something I have a strong opinion about, just saw an opportunity to close an easy issue 😀 |
|
How about we add a dev warning too then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #643