Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote class property name in attributes. #831

Merged
merged 2 commits into from
Sep 9, 2017

Conversation

jacobmischka
Copy link
Contributor

Fixes #830

@Conduitry
Copy link
Member

It might be nice to check the options.legacy option introduced in #778 for this.

Are there any other attribute names that we're likely to want to quote on legacy browsers?

@jacobmischka
Copy link
Contributor Author

jacobmischka commented Sep 8, 2017

Please let me know if I should add a test somewhere, I couldn't quite tell if this is the kind of thing that's usually tested in this project.

@Conduitry
Copy link
Member

When I was working on a project where IE9 support was required, one of the things that kept coming up was that IE9 loved to switch to IE8 compatibility mode at the slightest hint of a provocation. Luckily for my sanity, I've since completely forgotten what these triggers were, but that might be what's happening to you.

@jacobmischka
Copy link
Contributor Author

Oh interesting, thanks for the suggestion! And sorry about removing that complaint of mine you're referring to, I decided it made more in the issue instead ha.

@jacobmischka
Copy link
Contributor Author

You were right, it was in quirks mode for some reason. Changing to IE9 standard mode instead fixed it. Thanks a bunch!

@Rich-Harris Rich-Harris merged commit 91e04da into sveltejs:master Sep 9, 2017
@Rich-Harris
Copy link
Member

Added a snapshot test, just to be safe — thanks for the PR 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants