Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove let variable from select binding dependencies #8969

Merged
merged 3 commits into from
Jul 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cyan-geese-film.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: remove `let:variable` slot bindings from select binding dependencies
2 changes: 1 addition & 1 deletion packages/svelte/src/compiler/compile/internal_exports.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,9 @@ export default class AttributeWrapper extends BaseAttributeWrapper {
if (select && select.select_binding_dependencies) {
select.select_binding_dependencies.forEach((prop) => {
this.node.dependencies.forEach((dependency) => {
this.parent.renderer.component.indirect_dependencies.get(prop).add(dependency);
if (this.node.scope.is_top_level(dependency)) {
this.parent.renderer.component.indirect_dependencies.get(prop).add(dependency);
}
});
});
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<script>
const tasks = ["do laundry", "do taxes", "cook food", "watch the kids"];
</script>

<slot {tasks} />

Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
export default {
html: `
<select>
<option value='do laundry'>do laundry</option>
<option value='do taxes'>do taxes</option>
<option value='cook food'>cook food</option>
<option value='watch the kids'>watch the kids</option>
</select>
<p>1</p>
`,

async test({ assert, component, target, window }) {
const select = target.querySelector('select');
const options = target.querySelectorAll('option');

assert.equal(component.tasks_touched, 1);

const change = new window.Event('change');
options[1].selected = true;
await select.dispatchEvent(change);

assert.equal(component.selected, options[1].value);
assert.equal(component.tasks_touched, 1);
}
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<script>
import Parent from "./Parent.svelte";
export let selected;
export let tasks = ['do nothing'];
export let tasks_touched = 0;

$: {
tasks, tasks_touched++;
}
</script>

<Parent let:tasks={tasks}>
<select bind:value={selected}>
{#each tasks as task}
<option value={task}>{task}</option>
{/each}
</select>
</Parent>
<p>{tasks_touched}</p>
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<script>
const tasks = ["do laundry", "do taxes", "cook food", "watch the kids"];
</script>

<slot {tasks} />

Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
export default {
html: `
<select>
<option value='do laundry'>do laundry</option>
<option value='do taxes'>do taxes</option>
<option value='cook food'>cook food</option>
<option value='watch the kids'>watch the kids</option>
</select>
`,

async test({ assert, component, target, window }) {
const select = target.querySelector('select');
const options = target.querySelectorAll('option');

const change = new window.Event('change');
options[1].selected = true;
await select.dispatchEvent(change);

assert.equal(component.selected, options[1].value);
}
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<script>
import Parent from "./Parent.svelte";
export let selected;
</script>

<Parent let:tasks={tasks}>
<select bind:value={selected}>
{#each tasks as task}
<option value={task}>{task}</option>
{/each}
</select>
</Parent>