Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update major dependencies #242

Merged
merged 6 commits into from
Jan 4, 2022
Merged

chore: update major dependencies #242

merged 6 commits into from
Jan 4, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jan 1, 2022

Including minor dependencies.

execa and node-fetch aren't updated since the latest major version are ESM only, which wouldn't work in Jest.

sirv is removed, since it wasn't used anywhere.

@bluwy
Copy link
Member Author

bluwy commented Jan 1, 2022

Blocked by sveltejs/kit#3169 and sveltejs/kit#3159. I've downgraded SvelteKit to next.210 to fix the first issue, but now the CI fails on the second issue. I think we can fix them first, then continue on this PR.

@bluwy
Copy link
Member Author

bluwy commented Jan 3, 2022

Test failed twice:

  1. SvelteKit hydrates faster than expected, fails the SERVER_LOADED check (It's already CLIENT_LOADED)
  2. Two continuous server console.log apparently has the chance of being a single string from the string array e2eServer.logs.server.out

These are strange but this PR should be safe now.

@bluwy bluwy merged commit 65b29c7 into main Jan 4, 2022
@bluwy bluwy deleted the update-major-deps branch January 4, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants