Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(init): adds often used suffixes to some of the initial rules #917

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Mar 5, 2024

Description

  • modifications to the rules & configuration --init generates by default when setting up dependency-cruiser in a new repository:
    • adds .jsx, .tsx, .mts and .cts extensions to some fo
    • uses non-capturing groups in regexes that don't need groups to be capturing
    • remove regex grouping where it isn't needed (either to group expressions or to make a regex more readable)
    • also consider apps and libs as folders to collapse to for the archi reporter config in addition to app and lib (and other generic folder names like src etc).
  • apply some of these to dependency-cruiser own .dependency-cruiser.json

Motivation and Context

How Has This Been Tested?

  • green ci
  • generate a .dependency-cruiser.js and with that do a self-cruise

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

Copy link

codeclimate bot commented Mar 5, 2024

Code Climate has analyzed commit 0454452 and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij merged commit 0c5ed56 into main Mar 5, 2024
10 checks passed
@sverweij sverweij deleted the bugfix/refresh-init-config-regexes branch March 5, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue: not-to-spec and not-to-dev-dep default config should include tsx and jsx
1 participant