Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refracting from generic to semantic ApiDOM should retain original attribute & meta #3842

Closed
7 tasks done
char0n opened this issue Feb 21, 2024 · 10 comments
Closed
7 tasks done
Assignees
Labels
ApiDOM enhancement New feature or request

Comments

@char0n
Copy link
Member

char0n commented Feb 21, 2024

I'm not sure if the current code retains attributes & meta. First we need to research if it does and then compensate if if doesn't.

TODO:

  • API Design System namespace
  • OpenAPI 2.0 namespace
  • AsyncAPI 2.x namespace
  • JSON Schema namespaces
  • OpenAPI 3.0.x namespace
  • OpenAPI 3.1.0 namespace
  • Workflows 1 namespace

Update: confirmed. attributes & meta are not translated when doing Generic -> Semantic refracting.

@char0n
Copy link
Member Author

char0n commented Feb 21, 2024

In order to build the meta & attributes retainment, mergeRight and mergeLeft functions needs to be introduced: #3845

@char0n
Copy link
Member Author

char0n commented Feb 23, 2024

Merging of meta & attributes while merging ApiDOM elements is dealt in: #3853

char0n added a commit that referenced this issue Feb 24, 2024
This change is specific to cases when semantic ApiDOM is refractored
from generic ApiDOM.

Refs #3842
@char0n
Copy link
Member Author

char0n commented Feb 24, 2024

OpenAPI 2.0 namespace addressed in #3844

char0n added a commit that referenced this issue Feb 24, 2024
This change is specific to cases when semantic ApiDOM is refractored
from generic ApiDOM.

Refs #3842
@char0n
Copy link
Member Author

char0n commented Feb 24, 2024

API Design Systems namespace addressed in #3857

char0n added a commit that referenced this issue Feb 24, 2024
This change is specific to cases when semantic ApiDOM is refractored
from generic ApiDOM.

Refs #3842
char0n added a commit that referenced this issue Feb 24, 2024
This change is specific to cases when semantic ApiDOM is refractored
from generic ApiDOM.

Refs #3842
@char0n
Copy link
Member Author

char0n commented Feb 24, 2024

AsyncAPI 2.x namespace addressed in #3858

char0n added a commit that referenced this issue Feb 24, 2024
This change is specific to cases when semantic ApiDOM is refractored
from generic ApiDOM.

Refs #3842
char0n added a commit that referenced this issue Feb 24, 2024
This change is specific to cases when semantic ApiDOM is refractored
from generic ApiDOM.

Refs #3842
@char0n
Copy link
Member Author

char0n commented Feb 24, 2024

OpenAPI 3.0.x namespace addressed in #3859

char0n added a commit that referenced this issue Feb 24, 2024
This change is specific to cases when semantic ApiDOM is refractoredfrom generic ApiDOM.

Refs #3842
char0n added a commit that referenced this issue Feb 24, 2024
This change is specific to cases when semantic ApiDOM is refractoredfrom generic ApiDOM.

Refs #3842
@char0n
Copy link
Member Author

char0n commented Feb 24, 2024

Workflows 1 namespace addressed in #3860

char0n added a commit that referenced this issue Feb 24, 2024
This change is specific to cases when semantic ApiDOM is refractored
from generic ApiDOM.

Refs #3842
char0n added a commit that referenced this issue Feb 24, 2024
This change is specific to cases when semantic ApiDOM is refractored
from generic ApiDOM.

Refs #3842
char0n added a commit that referenced this issue Feb 24, 2024
This change is specific to cases when semantic ApiDOM is refractored
from generic ApiDOM.

Refs #3842
@char0n
Copy link
Member Author

char0n commented Feb 24, 2024

OpenAPI 3.1.0 namespace addressed in #3861

char0n added a commit that referenced this issue Feb 24, 2024
This change is specific to cases when semantic ApiDOM is refractored
from generic ApiDOM.

Refs #3842
@char0n
Copy link
Member Author

char0n commented Feb 24, 2024

JSON Schema namespaces addressed in #3862

@char0n
Copy link
Member Author

char0n commented Feb 24, 2024

The scope of the issue has been completed.

@char0n char0n closed this as completed Feb 24, 2024
char0n added a commit that referenced this issue Feb 24, 2024
This change is specific to cases when semantic ApiDOM is refractored
from generic ApiDOM.

Refs #3842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ApiDOM enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant