Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fold JSON parser syntactic analysis with transform phase #406

Closed
Tracked by #385
char0n opened this issue May 14, 2021 · 0 comments · Fixed by #407
Closed
Tracked by #385

Fold JSON parser syntactic analysis with transform phase #406

char0n opened this issue May 14, 2021 · 0 comments · Fixed by #407
Assignees
@char0n
Labels
ApiDOM enhancement New feature or request JSON

Comments

@char0n
Copy link
Member

char0n commented May 14, 2021

More info here #385
@char0n char0n added enhancement New feature or request ApiDOM JSON labels May 14, 2021
@char0n char0n self-assigned this May 14, 2021
@char0n char0n mentioned this issue May 14, 2021
Open
10 tasks
char0n added a commit that referenced this issue May 19, 2021
@char0n
perf(perser-adaper-json): fold syntactic analysis phases
4037e04 
Code of the parser have been consolidate into idiomatic
parsing phases: lexical and syntactic analysis.

There are two types of syntactic analysis: direct and indirect.

Indirect syntactic analysis is refactored and simplified original code
which turncs CST into JSON AST and then into ApiDOM.
Direct one is a new one which turns CST directly into ApiDOM.
Switching syntactic analysis is possible via configuration option.

Performance of direct syntactic analysis has been increased by
300% comparsing to original code.

Performance of indirect syntactic analysis has been increased by
10% comparing to original code and has been significantly simplified.

Closes #406
@char0n char0n mentioned this issue May 19, 2021
Merged
char0n added a commit that referenced this issue May 19, 2021
@char0n
perf(perser-adaper-json): fold syntactic analysis phases
c983b47 
Code of the parser have been consolidate into idiomatic
parsing phases: lexical and syntactic analysis.

There are two types of syntactic analysis: direct and indirect.

Indirect syntactic analysis is refactored and simplified original code
which turncs CST into JSON AST and then into ApiDOM.
Direct one is a new one which turns CST directly into ApiDOM.
Switching syntactic analysis is possible via configuration option.

Performance of direct syntactic analysis has been increased by
300% comparsing to original code.

Performance of indirect syntactic analysis has been increased by
10% comparing to original code and has been significantly simplified.

Closes #406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@char0n char0n

Labels
ApiDOM enhancement New feature or request JSON
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf(perser-adaper-json): fold syntactic analysis phases swagger-api/apidom
1 participant
@char0n