Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ls): temporary quick fix false positive for schema reference #2980

Closed
wants to merge 1 commit into from

Conversation

frantuma
Copy link
Member

@char0n

Refs swagger-api/swagger-editor#3722
Refs swagger-api/swagger-editor#4026

This is a temporary quick fix to avoid false positives in OAS 3.0.x anyOf, oneOf and allOf constructs, until the "real" underlying issue in schema parsing in OAS 3.0 spec is resolved (e.g. adding referenced-element meta or other solution)

This fix would cause a reference to a non schema not to be considered as error for OAS 3.0, but that missing negative is IMO less annoying for users as the current false positive

@frantuma frantuma requested a review from char0n July 24, 2023 12:34
@char0n
Copy link
Member

char0n commented Jul 24, 2023

I'll see if I can add referenced-element to the meta during tomorrow morning. The code is there, so it should be adding referenced-element when expected, but there must be a bug, which is preventing

@char0n
Copy link
Member

char0n commented Jul 25, 2023

@frantuma addressed missing meta in OpenAPI 3.0.x namespace: #2987

Can you rebase this PR against main branch and see it works as expected?

@frantuma
Copy link
Member Author

replaced by #2987 which fixes swagger-api/swagger-editor#3722 and swagger-api/swagger-editor#4026

@frantuma frantuma closed this Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants