-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(converter): add infoSummaryRefractorPlugin #3848
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Two small nitpicks detected.
...idom-converter/src/strategies/openapi-3-1-to-openapi-3-0-3/refractor-plugins/info-summary.ts
Outdated
Show resolved
Hide resolved
...nverter/test/strategies/openapi-3-1-to-openapi-3-0-3/refractor-plugins/info-summary/index.ts
Outdated
Show resolved
Hide resolved
@kowalczyk-krzysztof notice I've change the commit msg and it's body. Would be ideal if this PR will eventually gets sqashed+merged to following commit msg:
The commit message header is consistent with the previous ones - The commit body explains what this plugin is actually about. The commit footer references the public GitHub epic associated with converter: #3697 |
957fb02
to
2a24492
Compare
Thanks for the comment. I'll make sure to use this convention from now on. |
This plugin removes the summary fixed field of Info Object. Refs #3697
2a24492
to
92d53f0
Compare
The tests are failing. Probably other tests got affected by new plugin. |
It was the change from |
@kowalczyk-krzysztof please don't rebase the PRs into single commits. By doing this we loose all the history of the PR and comments attached to specific commit changes. GitHub has a squash and merge functionality directly available: After clicking it allows you to modify entire commit message: |
This plugin removes the
summary
fixed field ofInfo Object
.Refs SWG-9954