fix: bring back discriminator initialization to where it was before #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This 👍 I hope somebody can review it soon |
|
@HugoMario Could you take a look ? It seems you have worked on a related issue earlier last summer. |
|
thanks a lot @kaibra for this PR!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: #620 , which was introduced in
1.0.19, seems to be causing multiple issues (eg #654).This PR aims at fixing two issues:
fixes #686
fixes swagger-api/swagger-codegen#10198
Both issues are about missing polymorphic jackson annotations (
JsonSubTypes,JsonTypeInfo).The issue was caused by moving the initialization of the
discriminatorinto theComposedSchemablock (5d22382#diff-371437d4e9e09ea18f2ff29dbacd0e84L1279).In the examples mentioned in the issues, the model is not a
ComposedSchema.But the
discriminatorneeds to be initialized for the annotations to be generated, but it is only forComposedSchemas now.This PR moves the initialization back to where it was before.
I am not quite sure if this has other side-effects, I did not see. It looks like there are a bunch of cases untested?!
Still I hope this might speed up things in case it gets approved.
Cheers,
Kai