Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suffix enum name with classname to avoid conflict #9208

Closed
wants to merge 2 commits into from
Closed

suffix enum name with classname to avoid conflict #9208

wants to merge 2 commits into from

Conversation

CatTail
Copy link
Contributor

@CatTail CatTail commented Feb 23, 2019

fix #7300

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

When building a client with enums, it is possible to run into collisions using Go because the enum names are in the same name space.

@frantuma
Copy link
Member

frantuma commented Mar 6, 2019

included and replaced by #9234

@CatTail
Copy link
Contributor Author

CatTail commented Mar 6, 2019

@frantuma thank you!

@CatTail CatTail closed this Mar 6, 2019
@CatTail CatTail deleted the bugfix/go-enum-conflict branch March 6, 2019 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Go] 2.3.0 enum support can lead to collisions
2 participants