Implementing additionalProperties to Schema and Boolean #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gracekarina
changed the title
frantuma
requested changes
Jan 12, 2018
|
|
||
| String str = client.invokeAPI("/mockResponses/additionalPropertiesTest", "GET", queryParams, null, new HashMap<String, String>(), null, "application/json", null, new String[0]); | ||
| assertEquals(str, "{\"key\":\"key\",\"value\":\"string\"}"); | ||
| } |
There was a problem hiding this comment.
doesn't seem right, should be something like "{\"foo\":0,\"additionalPropertyExampleKey\":\"string\"}"
There was a problem hiding this comment.
I changed the code, and try not to break the older tests in the process
|
|
||
| String str = client.invokeAPI("/mockResponses/additionalProperties1", "GET", queryParams, null, new HashMap<String, String>(), null, "application/json", null, new String[0]); | ||
| assertEquals(str, "{\"key\":\"key\",\"value\":{\"bar\":0}}"); | ||
| } |
There was a problem hiding this comment.
doesn't seem right, should be something like "{\"foo\":0,\"additionalPropertyExampleKey\":{\"bar\":0}}}"
There was a problem hiding this comment.
I changed the code, and try not to break the older tests in the process
|
|
||
| String str = client.invokeAPI("/mockResponses/badAdditionalProperties", "GET", queryParams, null, new HashMap<String, String>(), null, "application/json", null, new String[0]); | ||
| assertEquals(str, "{\"foo\":0}"); | ||
| } |
There was a problem hiding this comment.
why "Bad"? change to "False" or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs swagger-api/swagger-core#2461 - swagger-api/swagger-parser#499