Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension to keep track of original swagger version #1374

Merged
merged 4 commits into from
Jul 4, 2020

Conversation

sebastien-rosset
Copy link
Contributor

@sebastien-rosset sebastien-rosset commented May 15, 2020

This is a proposed change to retain the original value of the "swagger" keyword when converting a OAS/Swagger 2.0 document to a 3.0 OAS document.

@sebastien-rosset sebastien-rosset marked this pull request as ready for review May 15, 2020 23:48
@gracekarina
Copy link
Contributor

Hi @sebastien-rosset can you please update the branch so we can merge? thanks!

@sebastien-rosset
Copy link
Contributor Author

Hi @sebastien-rosset can you please update the branch so we can merge? thanks!

Done. Just a thought, how about renaming the extension to x-original-openapi-version? In the future, there may be a similar use case when version 3 is converted to version 4, so it makes more sense to use openapi instead of swagger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants