Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1 PR with comment change, shows CI failing for v1 branch #1415

Closed
wants to merge 2 commits into from
Closed

v1 PR with comment change, shows CI failing for v1 branch #1415

wants to merge 2 commits into from

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Aug 4, 2020 •
edited
Loading

v1 PR with comment change, shows CI failing for v1 branch

@spacether spacether changed the title [Test-PR] ignore this v1 PR with comment change, shows CI failing for v1 branch Aug 4, 2020
@spacether spacether mentioned this pull request Aug 4, 2020
Closed
@spacether
Copy link
Contributor Author

spacether commented Aug 4, 2020 •
edited
Loading

Tests were fixed by mocking out the calls to get the petstore spec from http://petstore.swagger.io/v2/swagger.json
Closing this PR because the commit that fixes those tests has been pulled into #1414

The calls to the url resource were returning:

<html>
<head><title>302 Found</title></head>
<body bgcolor="white">
<center><h1>302 Found</h1></center>
</body>
</html>

Which shows that the code is not following the redirection Location header.

@spacether spacether closed this Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@spacether