Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes checks related to OperationView.js content-disposition headers #1238

Closed
wants to merge 1 commit into from

Conversation

zupper
Copy link

@zupper zupper commented May 5, 2015

Basically did what was left to do in PR #1122 (related to issue #1196). Also PR is to develop_2.0 this time...

@lukasznowak-silvair
Copy link

I did some tests to check this fix and I see some strange behavior:

My response from REST API:

{
  "date": "Thu, 07 May 2015 12:22:21 GMT",
  "content-disposition": "attachment; filename=\"icons.tgz\"",
  "connection": "Keep-Alive",
  "keep-alive": "timeout=5, max=100",
  "transfer-encoding": "chunked",
  "server": "Jetty(8.1.15.v20140411)",
  "content-type": "application/octet-stream"
}

After "Try it out!" I get Response Body:

Download icon?token=364edd8ab7be2e36

After download the file name is

application-octet-stream-icon-token=364edd8ab7be2e36-blob-https%3A--domain.com-b7c305ac-29c1-48ec-ad6b-9dc62c28fff8

What is more the content of the file is different. I do not know if this is related to this fix or this is some old bug.

@zupper
Copy link
Author

zupper commented May 8, 2015

@lnowak, I don't think the situation you describe is related to this fix. This merely adds an improved check for specific headers so that the app wouldn't crash with a NPE. The only source file that was changed is src/main/javascript/view/OperationView.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants