Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML response body formatting performance #3862

Merged
merged 6 commits into from
Nov 2, 2017

Conversation

shockey
Copy link
Contributor

@shockey shockey commented Nov 2, 2017

Description

This PR removes our internal formatXml utility function in favor of xml-but-prettier.

This change cuts our time spent rendering a 2MB XML payload from 78s to 1.3s.

Motivation and Context

Fixes #3832!

How Has This Been Tested?

  • I tested an XML Try-It-Out endpoint before and after the change.
  • xml-but-prettier has its own tests.

Types of changes

  • No code changes (changes to documentation, CI, metadata, etc)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shockey shockey mentioned this pull request Nov 2, 2017
@shockey shockey merged commit be34c8d into master Nov 2, 2017
@shockey shockey deleted the bug/3858-xml-formatting-perf branch November 30, 2017 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large response bodies cause hanging
2 participants