Problem with swaggo/gin-swagger -> github.com/ugorji/go v1.1.5-pre

[nickarsar]

Have problem with go mod download in project using swag:

go: github.com/swaggo/[email protected] requires github.com/swaggo/[email protected] requires github.com/ugorji/[email protected] requires github.com/ugorji/go/[email protected]: reading github.com/ugorji/go/codec/codec/go.mod at revision codec/v1.1.5-pre: unknown revision codec/v1.1.5-pre

This helped me:
replace github.com/swaggo/gin-swagger v1.2.0 => github.com/swaggo/gin-swagger v1.3.0

Related issue: swaggo/gin-swagger#128

[jakesylvestre]

@nickarsar I fixed this in #825, but no release was made. For now you can use
github.com/swaggo/swag v1.6.10-0.20201104153820-3f47d68f8872

@ubogdan might make sense to release what's on master now

Also, one word of caution on replace that I found out the hardway fixing this. replace doesn't fix downstream modules (e.g. any module that depends on the module using the replace also requires you to manually add the replace). It doesn't look like go plans on changing this behavior any time soon (see golang/go#30354)

[kkontus]

Can this thing be fixed in http-swagger as well, please :)?

[stigok]

This is still an issue! To reproduce

$ mkdir hello
$ cd hello
$ go mod init hello
$ go get github.com/swaggo/swag/cmd/swag
go: found github.com/swaggo/swag/cmd/swag in github.com/swaggo/swag v1.6.9
go get: github.com/swaggo/[email protected] requires
	github.com/swaggo/[email protected] requires
	github.com/ugorji/[email protected] requires
	github.com/ugorji/go/[email protected]: reading github.com/ugorji/go/codec/codec/go.mod at revision codec/v1.1.5-pre: unknown revision codec/v1.1.5-pre

[kkontus]

yes, exactly. Shouldn't this be just matter of creating tag v1.1.5-pre or remove dependencies to it?

[jakesylvestre]

Dependencies were removed in 3f47d68, but no release has been made since then. Is the workaround here not working?

[kkontus]

@jakesyl oh, I missed that, thank you very much mate, it works 👏

[akojo]

#800 removes dependency on gin-swagger altogether so this should be fixed in the next release

[ghost]

#800 removes dependency on gin-swagger altogether so this should be fixed in the next release

Removing github.com/ugorji/go as a dependency seems like a smart move. It's forever breaking downstream repos with tags being deleted and go module weirdness.

This issue is currently blocking some of our builds - any ideas when it'll be released? The release is also a blocker for fixing this swaggo/http-swagger#36

Cheers.

[ubogdan]

Closing: fixed.