Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to brick 2.0 #1607

Closed
xsebek opened this issue Oct 31, 2023 · 5 comments · Fixed by #1617
Closed

Migrate to brick 2.0 #1607

xsebek opened this issue Oct 31, 2023 · 5 comments · Fixed by #1617
Labels
C-Low Hanging Fruit Ideal issue for new contributors. P-Windows Issue affecting the Windows platform. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. T-UI Involves the user interface. Z-Feature A new feature to be added to the game. Z-Meta This issue is about other Swarm issues or infrastructure. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality.

Comments

@xsebek
Copy link
Member

xsebek commented Oct 31, 2023

vty 6.0 and brick 2.0 support windows! 🚀 So we could too and close #53
@xsebek xsebek added the Z-Feature A new feature to be added to the game. label Oct 31, 2023
@byorgey byorgey added Z-Meta This issue is about other Swarm issues or infrastructure. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality. C-Low Hanging Fruit Ideal issue for new contributors. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. T-UI Involves the user interface. P-Windows Issue affecting the Windows platform. labels Oct 31, 2023
@jtdaugherty
Copy link

We might have a wrinkle or two left to work out, but heavier users of vty like swarm will help us surface remaining issues. Keep me and @chhackett in the loop!

@chhackett chhackett mentioned this issue Nov 11, 2023
Merged
@byorgey byorgey linked a pull request Nov 11, 2023 that will close this issue
Update to support running on Windows #1617
Merged
@chhackett
Copy link
Contributor

Hello,
I updated the cabal and App module to allow for running on Windows. I did some playtesting, and I didn't find any rendering or gameplay issues. All the keyboard commands seem to behave well. I've addressed comments on the PR.

Keep in mind that right now only command line and Powershell terminals are supported.

Btw, what a neat game!

@chhackett
Copy link
Contributor

Actually, I do see 2 issues so far:

  • mouse mode isn't working for some reason
  • program expects the data files to be present in the C:\Users\Chris\AppData\Roaming\swarm\data directory. Or is that a feature? Not sure, haven't played it before...

@chhackett
Copy link
Contributor

Disregard my previous comment about mouse mode. I did not realize mouse mode was only enabled for some menus. For example, the main menu doesn't respond to mouse clicks, but other UI elements do. So mouse mode does work.

@byorgey
Copy link
Member

byorgey commented Nov 12, 2023

program expects the data files to be present in the C:\Users\Chris\AppData\Roaming\swarm\data directory. Or is that a feature? Not sure, haven't played it before...

That's normal. You can get the latest data files from https://github.com/swarm-game/swarm/releases under swarm-data.zip. That actually reminds me that if we are updating to support Windows we should probably include changes to https://swarm-game.github.io/installing/ to mention the proper instructions. But we can do that separately.

@mergify mergify bot closed this as completed in #1617 Nov 14, 2023
mergify bot pushed a commit that referenced this issue Nov 14, 2023
@chhackett
Update to support running on Windows (#1617)
ca1918a 
Added support for running on Windows, in command line or Powershell terminals.

Currently terminal emulators such as mintty, ConEmu, alacritty, etc are not supported.

Addresses issues #1607 and #53.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Low Hanging Fruit Ideal issue for new contributors. P-Windows Issue affecting the Windows platform. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. T-UI Involves the user interface. Z-Feature A new feature to be added to the game. Z-Meta This issue is about other Swarm issues or infrastructure. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to support running on Windows chhackett/swarm
4 participants
@jtdaugherty @byorgey @chhackett @xsebek