Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to GHC 9.4 and brick 1.5 #1001

Merged
merged 5 commits into from
Jan 30, 2023
Merged

Update to GHC 9.4 and brick 1.5 #1001

merged 5 commits into from
Jan 30, 2023

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Jan 11, 2023 •
edited by byorgey
Loading

A couple upgrades:

@restyled-io restyled-io bot mentioned this pull request Jan 11, 2023
Closed
@byorgey byorgey linked an issue Jan 11, 2023 that may be closed by this pull request
Upgrade to brick-1.5 #878
Closed
byorgey
byorgey reviewed Jan 28, 2023
View reviewed changes
swarm.cabal Outdated Show resolved Hide resolved
@byorgey
Copy link
Member

byorgey commented Jan 28, 2023

@kostmo do you have a sense of what would be required to finish this? Can I help? I'd love to get this merged since #1000 is very annoying. It's easy to work around for more experienced developers but I'd really like to be able to continue telling people to stack run and have it just work.

@kostmo
Copy link
Member Author

kostmo commented Jan 29, 2023

Can I help?

I'll happily hand this over to you if you want to finish it. Mostly I think the work entails creating and assigning new members of the Name type to dialog buttons.

@byorgey
Copy link
Member

byorgey commented Jan 29, 2023

OK, I'll take a look.

@restyled-io restyled-io bot mentioned this pull request Jan 29, 2023
Merged
kostmo
kostmo commented Jan 29, 2023
View reviewed changes
src/Swarm/TUI/Model/Name.hs Outdated Show resolved Hide resolved
@byorgey byorgey mentioned this pull request Jan 30, 2023
Closed
2 tasks
@byorgey byorgey marked this pull request as ready for review January 30, 2023 10:45
@byorgey byorgey changed the title PoC for GHC 9.4 Update to GHC 9.4 and brick 1.5 Jan 30, 2023
@byorgey byorgey requested a review from xsebek January 30, 2023 10:49
@xsebek
Copy link
Member

xsebek commented Jan 30, 2023

@byorgey should we merge it before release?

xsebek
xsebek approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@xsebek xsebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@byorgey byorgey added the merge me Trigger the merge process of the Pull request. label Jan 30, 2023
@mergify mergify bot merged commit 61a3d43 into main Jan 30, 2023
@mergify mergify bot deleted the ghc-9.4-proof-of-concept branch January 30, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey left review comments

@xsebek xsebek xsebek approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to brick-1.5
3 participants
@kostmo @byorgey @xsebek