Check that base has a logger installed in tutorial #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xsebek
commented
Jan 31, 2023
xsebek
commented
- closes test that all tutorial scenarios have a logger #1072
byorgey
approved these changes
Jan 31, 2023
| let baseDevs = gs ^?! baseRobot . equippedDevices | ||
| in assertBool "Base should have a logger installed!" (not . null $ lookupByName "logger" baseDevs) | ||
|
|
||
| testTutorialSolution t f = testSolution' t f CheckForBadErrors tutorialHasLog |
There was a problem hiding this comment.
Could testTutorialSolution be defined in terms of testTutorialSolution'?
There was a problem hiding this comment.
Sure, but given the order of parameters, you would not gain anything right now.
If we add more conditions, then it might be worth refactoring. 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.