Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rightward bleeding of custom attributes #1137

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Fix rightward bleeding of custom attributes #1137

merged 2 commits into from
Mar 1, 2023

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Mar 1, 2023 •
edited
Loading

Previously, custom attributes with only a foreground or only a background set would inherit the foreground/background to the left of them. This is due to mistakenly using currentAttr instead of defAttr in #1058.

Version Screenshot
Before Screenshot from 2023-02-28 22-38-55
Fixed Screenshot from 2023-02-28 22-44-20

@kostmo kostmo changed the title Custom attr bg bleed Fix rightward bleeding of custom attributes Mar 1, 2023
@kostmo kostmo marked this pull request as ready for review March 1, 2023 06:51
@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Mar 1, 2023
@mergify mergify bot merged commit 4dba124 into main Mar 1, 2023
@mergify mergify bot deleted the custom-attr-bg-bleed branch March 1, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostmo @byorgey