Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pig capturing scenario #1258

Merged
merged 3 commits into from
May 15, 2023
Merged

Pig capturing scenario #1258

merged 3 commits into from
May 15, 2023

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented May 13, 2023

scripts/play.sh --scenario data/scenarios/Challenges/capture.yaml

Screenshot from 2023-05-13 15-17-31

@kostmo kostmo changed the title Pig capturing scenario [WIP] Pig capturing scenario May 13, 2023
@kostmo kostmo force-pushed the synchronized-capture branch 4 times, most recently from 96b303f to 1fe40ec Compare May 15, 2023 07:54
@kostmo kostmo marked this pull request as ready for review May 15, 2023 07:54
@kostmo kostmo requested a review from byorgey May 15, 2023 07:54
@kostmo kostmo changed the title [WIP] Pig capturing scenario Pig capturing scenario May 15, 2023
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I actually solved it by first arranging the monoliths one cell away from the pig, as in the model solution, and then building four robots to sit behind them and wait for a specific time using the time command, then all push simultaneously at the agreed-upon time. If you want to disallow that and force the use of watch then you could remove the clocks from the inventory.

In any case I think the descriptions of a few of the devices should be improved; I happened to know about the push and watch commands already, but I think a new player would have a very hard time figuring out what they are supposed to do. Of course we should also consider having these devices be canonically available in the list of default entities, but that's probably for another PR.

attr: silver
char: '/'
description:
- Facilitates pushing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description needs to explain the push command, since other than looking through the long list in the commands dialog, I don't think there's any way for the player to discover what exactly "facilitates pushing" means.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a prerequisite PR, I will extract the devices that provide push and watch to canonical entities. But I will defer creating a recipe for them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also see #1262

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data/scenarios/Challenges/capture.yaml Outdated Show resolved Hide resolved
data/scenarios/Challenges/capture.yaml Outdated Show resolved Hide resolved
data/scenarios/Challenges/capture.yaml Outdated Show resolved Hide resolved
data/scenarios/Challenges/capture.yaml Outdated Show resolved Hide resolved
data/scenarios/Challenges/capture.yaml Outdated Show resolved Hide resolved
attr: silver
char: '/'
description:
- Facilitates pushing
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a prerequisite PR, I will extract the devices that provide push and watch to canonical entities. But I will defer creating a recipe for them.

@kostmo kostmo force-pushed the synchronized-capture branch 2 times, most recently from 2a18069 to b1f345e Compare May 15, 2023 22:03
@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label May 15, 2023
@mergify mergify bot merged commit 0e286c0 into main May 15, 2023
@mergify mergify bot deleted the synchronized-capture branch May 15, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants