Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load persistent state from disk only once and reuse for all integration tests #1383

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Load persistent state from disk only once and reuse for all integration tests #1383

merged 2 commits into from
Jul 20, 2023

Conversation

byorgey
Copy link
Member

@byorgey byorgey commented Jul 19, 2023

This seems to make a big difference --- the integration test suite now takes only about 35% as long as it used to. Fixes #1279.

@byorgey byorgey requested a review from kostmo July 19, 2023 18:30
kostmo
kostmo approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@kostmo kostmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark on my machine:

Before After
0m53.054s 0m26.622s

@byorgey byorgey added the merge me Trigger the merge process of the Pull request. label Jul 20, 2023
@mergify mergify bot merged commit 7203875 into main Jul 20, 2023
@mergify mergify bot deleted the load-test-state-once branch July 20, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostmo kostmo kostmo approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only initialize AppState once when running scenario tests
2 participants
@byorgey @kostmo