Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fishing scenario #1628

Merged
merged 3 commits into from
Feb 19, 2024
Merged

fishing scenario #1628

merged 3 commits into from
Feb 19, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Nov 15, 2023

This scenario makes use of several relatively recent features/commands:

  • structure placement
  • structure queries (for goal checking)
  • density command (for goal checking)
  • combustion
  • tags
  • goal prerequisites with boolean expressions

Demo

scripts/play.sh -i Challenges/Ranching/fishing.yaml --autoplay

image

@kostmo kostmo changed the title [WIP] fishing scenario fishing scenario Nov 20, 2023
@kostmo kostmo added the G-Scenarios An issue having to do with scenario design, the way scenarios are described and loaded, etc. label Nov 20, 2023
@kostmo kostmo marked this pull request as ready for review November 20, 2023 07:38
@kostmo kostmo requested a review from byorgey November 20, 2023 07:38
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fun! A few suggestions:

  1. The way the objectives are set up is confusing; see my inline comments and suggestions below.
  2. I never really switched out of "exploratory" mode and ended up solving the whole thing just typing a bunch of things manually at the REPL, without having to set up any kind of automation with tagmembers etc. What about adding a final objective that ramps up the numbers so that you are forced to actually write some generic code lest it be incredibly tedious? e.g. after you make one california roll, a new objective could be revealed that says you want to start your own sushi business so you need to make 32 california rolls (or something like that).

data/scenarios/Challenges/Ranching/fishing.yaml Outdated Show resolved Hide resolved
attrs:
- name: shark
bg: "#2040bb"
objectives:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The objectives are quite confusing. After completing the scenario by disposing of everything properly, I was confused why I still had not achieved the optional "no littering" objective. "But surely I did not litter!" I thought. "Why does it still think I have not completed that objective?" I thought perhaps everything had to be hauled away, so I spent some time doing more fishing until I had the perfect number of junk items so that the hauler could haul them away, but I still did not complete the objective.

It is only when I looked at this .yaml file that I realized that objective is "completed" when you do litter, and that completing it is actually bad! Do we have a way yet to mark an objective as "bad"/negative and display it with a different color / in a different section? I thought we had an issue for that but I can't find it now. In any case maybe just some text in the objective description would help that says something like "Note, this is an "anti-objective": it will be marked "completed" if you litter, which will cause you to fail the scenario. Don't litter!"

Even better, maybe the description for the No Littering goal can be moved into the Sushi chef goal description, and the No littering goal can be marked hidden. I think that would be a lot less confusing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a way yet to mark an objective as "bad"/negative and display it with a different color / in a different section? I thought we had an issue for that but I can't find it now.

Closest issue may be #1046.

Agreed that the goal presentation should be improved. Will look into it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better, maybe the description for the No Littering goal can be moved into the Sushi chef goal description, and the No littering goal can be marked hidden. I think that would be a lot less confusing.

Done.

.ii......wwwwwwwww.......r.
.........wwwwwwww........r.
.cc........wwww..........r.
.cc......................r.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to do placement of the rubbish enclosure by blind reckoning.

@kostmo
Copy link
Member Author

kostmo commented Feb 16, 2024

Added an objective to make 16 California rolls.

@kostmo kostmo marked this pull request as ready for review February 16, 2024 07:08
@kostmo kostmo force-pushed the scenario/fishing branch 2 times, most recently from 3407802 to 863f2c7 Compare February 18, 2024 00:21
@kostmo
Copy link
Member Author

kostmo commented Feb 19, 2024

ping for approval @byorgey

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Feb 19, 2024
@mergify mergify bot merged commit 95a9014 into main Feb 19, 2024
11 checks passed
@mergify mergify bot deleted the scenario/fishing branch February 19, 2024 20:20
@byorgey byorgey added the CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. G-Scenarios An issue having to do with scenario design, the way scenarios are described and loaded, etc. merge me Trigger the merge process of the Pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants