-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fishing scenario #1628
fishing scenario #1628
Conversation
ae551e8
to
fda1ce7
Compare
fda1ce7
to
6344f96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was fun! A few suggestions:
- The way the objectives are set up is confusing; see my inline comments and suggestions below.
- I never really switched out of "exploratory" mode and ended up solving the whole thing just typing a bunch of things manually at the REPL, without having to set up any kind of automation with
tagmembers
etc. What about adding a final objective that ramps up the numbers so that you are forced to actually write some generic code lest it be incredibly tedious? e.g. after you make one california roll, a new objective could be revealed that says you want to start your own sushi business so you need to make 32 california rolls (or something like that).
attrs: | ||
- name: shark | ||
bg: "#2040bb" | ||
objectives: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The objectives are quite confusing. After completing the scenario by disposing of everything properly, I was confused why I still had not achieved the optional "no littering" objective. "But surely I did not litter!" I thought. "Why does it still think I have not completed that objective?" I thought perhaps everything had to be hauled away, so I spent some time doing more fishing until I had the perfect number of junk items so that the hauler could haul them away, but I still did not complete the objective.
It is only when I looked at this .yaml
file that I realized that objective is "completed" when you do litter, and that completing it is actually bad! Do we have a way yet to mark an objective as "bad"/negative and display it with a different color / in a different section? I thought we had an issue for that but I can't find it now. In any case maybe just some text in the objective description would help that says something like "Note, this is an "anti-objective": it will be marked "completed" if you litter, which will cause you to fail the scenario. Don't litter!"
Even better, maybe the description for the No Littering goal can be moved into the Sushi chef goal description, and the No littering goal can be marked hidden. I think that would be a lot less confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a way yet to mark an objective as "bad"/negative and display it with a different color / in a different section? I thought we had an issue for that but I can't find it now.
Closest issue may be #1046.
Agreed that the goal presentation should be improved. Will look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even better, maybe the description for the No Littering goal can be moved into the Sushi chef goal description, and the No littering goal can be marked hidden. I think that would be a lot less confusing.
Done.
.ii......wwwwwwwww.......r. | ||
.........wwwwwwww........r. | ||
.cc........wwww..........r. | ||
.cc......................r. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have to do placement of the rubbish enclosure
by blind reckoning.
ff1f833
to
b2cba34
Compare
b2cba34
to
e45ecff
Compare
Added an objective to make 16 California rolls. |
3407802
to
863f2c7
Compare
863f2c7
to
5d800be
Compare
ping for approval @byorgey |
This scenario makes use of several relatively recent features/commands:
Demo