Only check for escaped skolem variables among those just generated #2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byorgey
commented
Aug 9, 2024
| , testCase | ||
| "nested polymorphic def/annot" | ||
| (valid "def id : a -> a * Int = \\y. (y, 3 : Int) end") | ||
| ] |
There was a problem hiding this comment.
These minimal test cases were failing before the fix.
xsebek
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2101.
skolemizeto return the list of generated variable names along with the substituted type (and remove an unnecessary call toerror!)noSkolemsonly check for relevant, recently-generated skolem variables instead of for any skolem variables at all.