More generic structure recognition #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostmo
changed the title
kostmo
changed the title
kostmo
force-pushed
the
expermiental/refine-recognizer-api-more
branch
3 times, most recently
from
17b5a83
to
62928d0
Compare
kostmo
force-pushed
the
expermiental/refine-recognizer-api-more
branch
from
62928d0
to
46b0171
Compare
kostmo
added
the
Z-Refactoring
byorgey
approved these changes
Aug 12, 2024
src/swarm-topography/Swarm/Game/Scenario/Topography/Structure/Recognition/Registry.hs
Outdated
Show resolved
Hide resolved
Co-authored-by: Brent Yorgey <[email protected]>
kostmo
force-pushed
the
expermiental/refine-recognizer-api-more
branch
from
67b8e24
to
5beffa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon #1836.
Most importantly in this PR, the
Swarm.Game.Scenario.Topography.Structure.Recognition.Trackingmodule is made generic in itsEntityparameter, and is now able to be moved from theswarm-enginesublibrary to theswarm-topologysublibrary.I've also introduced an intermediate
RecognitionStaterecord insideStructureRecognizerto distinguish between the stateful and read-only elements.The
AhoCorasickdependency is now reduced to only one sublibrary.