Make Rolex show time #2147
Merged
Make Rolex show time #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* show time when robot has `time` capability Prompted by #2146, which used the fancy `rollex` entity for commands but surprisingly did not show time in UI.
kostmo
approved these changes
Sep 15, 2024
xsebek
commented
Sep 15, 2024
Comment on lines
543
to
-548
| clockEquipped :: GameState -> Bool | ||
| clockEquipped gs = case focusedRobot gs of | ||
| Nothing -> False | ||
| Just r | ||
| | countByName "clock" (r ^. equippedDevices) > 0 -> True | ||
| | otherwise -> False |
There was a problem hiding this comment.
This might be the only instance of if p then True else False in repo.
I am surprised HLint did not spot it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timecapabilityPrompted by #2146, which used the fancy
rolexentity for commands but surprisingly did not show time in UI.You can test it with:
git cherry-pick ba8dae31 # see before and after adding rolex cabal run swarm -O0 -- -i data/scenarios/Testing/562-lodestone.yaml --speed 2 --autoplay