Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow latest versions of dependencies + GHC 9.4 #752

Merged
merged 4 commits into from
Oct 31, 2022
Merged

allow latest versions of dependencies + GHC 9.4 #752

merged 4 commits into from
Oct 31, 2022

Conversation

byorgey
Copy link
Member

@byorgey byorgey commented Oct 18, 2022

Update dependencies + add GHC 9.4 to CI. Closes #748 .

Latest versions of `witch` got rid of `From String Bytestring`
instance since the encoding is not specified.
@byorgey byorgey marked this pull request as ready for review October 30, 2022 19:51
@xsebek
Copy link
Member

xsebek commented Oct 31, 2022

I tried running integration tests and noticed that they were a few seconds slower.

Running benchmarks seems to confirm this:

Benchmark ghc810 ghc90 ghc92 ghc94
GeoMean (calculated) 1.00 -0.5% 62.1% 60.2%
run 1000 game ticks/circlers/10 0.27 -1.7% 9.6% 11.6%
run 1000 game ticks/circlers/20 0.53 1.6% 9.5% 9.3%
run 1000 game ticks/circlers/30 0.78 1.9% 11.1% 12.8%
run 1000 game ticks/circlers/40 1.06 8.8% 6.4% 8.3%
run 1000 game ticks/idlers/10 2.56e-3 -5.4% 144.9% 129.9%
run 1000 game ticks/idlers/20 2.71e-3 -11.4% 124.8% 113.8%
run 1000 game ticks/idlers/30 2.59e-3 -7.2% 129.6% 124.0%
run 1000 game ticks/idlers/40 2.53e-3 -2.0% 141.8% 133.2%
run 1000 game ticks/movers/10 0.47 6.6% 18.1% 18.5%
run 1000 game ticks/movers/20 0.98 8.5% 12.0% 16.6%
run 1000 game ticks/movers/30 1.46 6.9% 12.6% 17.6%
run 1000 game ticks/movers/40 1.94 1.8% 15.1% 15.1%
run 1000 game ticks/trees/10 2.48e-3 3.4% 142.1% 132.5%
run 1000 game ticks/trees/20 2.55e-3 -2.7% 137.9% 127.8%
run 1000 game ticks/trees/30 2.48e-3 -1.4% 146.0% 138.1%
run 1000 game ticks/trees/40 2.87e-3 -12.1% 115.0% 108.4%

I will update once I check this against other GHC versions. 🙂 UPDATE: GHC9.2 seems to be worse, so we can add GHC9.4 without regrets.

Copy link
Member

@xsebek xsebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 @byorgey should we also add it to the CI? I think we should have enough cache space for one more GHC, but if not we can drop GHC9.0. 🙂

Also switch `hlint` to run on 9.4.2.
@byorgey byorgey changed the title try allowing latest versions of dependencies + GHC 9.4 allow latest versions of dependencies + GHC 9.4 Oct 31, 2022
@byorgey byorgey added the merge me Trigger the merge process of the Pull request. label Oct 31, 2022
@byorgey
Copy link
Member Author

byorgey commented Oct 31, 2022

Adding GHC 9.4 to CI went flawlessly, though it took a very long time to build. Hopefully with caching it will speed up on subsequent runs, I am not quite sure how that works.

EDIT: yes, indeed, running CI on GHC 9.4 was much faster the second time.

@mergify mergify bot merged commit a4d0d23 into main Oct 31, 2022
@mergify mergify bot deleted the ghc-9.4 branch October 31, 2022 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Swarm to work with GHC 9.4 and latest package versions
2 participants