-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow latest versions of dependencies + GHC 9.4 #752
Conversation
Latest versions of `witch` got rid of `From String Bytestring` instance since the encoding is not specified.
I tried running integration tests and noticed that they were a few seconds slower. Running benchmarks seems to confirm this:
I will update once I check this against other GHC versions. 🙂 UPDATE: GHC9.2 seems to be worse, so we can add GHC9.4 without regrets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀 @byorgey should we also add it to the CI? I think we should have enough cache space for one more GHC, but if not we can drop GHC9.0. 🙂
Also switch `hlint` to run on 9.4.2.
Adding GHC 9.4 to CI went flawlessly, though it took a very long time to build. Hopefully with caching it will speed up on subsequent runs, I am not quite sure how that works. EDIT: yes, indeed, running CI on GHC 9.4 was much faster the second time. |
Update dependencies + add GHC 9.4 to CI. Closes #748 .