use nested sum type to simplify panel enumeration #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostmo
force-pushed
the
nested-sum-type-names
branch
3 times, most recently
from
8b4b7b7
to
8973fe7
Compare
kostmo
commented
Nov 21, 2022
kostmo
force-pushed
the
nested-sum-type-names
branch
from
8973fe7
to
b98cec6
Compare
kostmo
commented
Nov 22, 2022
| mouseCoordsM <- Brick.zoom gameState (mouseLocToWorldCoords mouseLoc) | ||
| uiState . uiWorldCursor .= mouseCoordsM | ||
| REPLInput -> do | ||
| setFocus REPLPanel |
kostmo
commented
Nov 22, 2022
| InventoryList -> Just RobotPanel | ||
| InventoryListItem _ -> Just RobotPanel | ||
| InfoViewport -> Just InfoPanel | ||
| REPLInput -> Just REPLPanel |
byorgey
approved these changes
Nov 22, 2022
Yes, exactly. I add a new panel in #873. |
kostmo
force-pushed
the
nested-sum-type-names
branch
from
b98cec6
to
0677da9
Compare
kostmo
force-pushed
the
nested-sum-type-names
branch
from
0677da9
to
15ffaa0
Compare
kostmo
commented
Nov 22, 2022
Comment on lines
+322
to
+326
| Just (FocusablePanel x) -> ($ ev) $ case x of | ||
| REPLPanel -> handleREPLEvent | ||
| WorldPanel -> handleWorldEvent | ||
| RobotPanel -> handleRobotPanelEvent | ||
| InfoPanel -> handleInfoPanelEvent infoScroll |
There was a problem hiding this comment.
Here's one more benefit of a dedicated sum type for Panels: we utilize exhuastiveness checking from the compiler here. The catch-all _ case no longer allows us to forget about a Panel; it instead handles all the non-panel Names.
mergify bot
pushed a commit
that referenced
this pull request
Jan 3, 2023
Code simplification, improved type safety (see [this comment](#876 (comment))). This technique may also simplify the implementation of `CReverse` (see #950) if we choose to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This trick facilitates use of
listEnumsand more concise pattern matching.Towards #873.