Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Scenario.hs #880

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Split Scenario.hs #880

merged 2 commits into from
Dec 12, 2022

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Dec 5, 2022

Partially towards #707, although Scenario.hs is not that large. Primarily this refactoring is in anticipation of #873 (see comment).

Just like #879, there are no functional changes in this PR---only code relocation.

@kostmo kostmo requested review from byorgey and xsebek December 5, 2022 03:25
@kostmo kostmo added the Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality. label Dec 5, 2022
@restyled-io restyled-io bot mentioned this pull request Dec 8, 2022
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I think we should rename Cells to Cell.

src/Swarm/Game/Scenario/Cells.hs Outdated Show resolved Hide resolved
@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Dec 12, 2022
@mergify mergify bot merged commit b87f159 into main Dec 12, 2022
@mergify mergify bot deleted the decompose-scenario-module branch December 12, 2022 00:43
mergify bot pushed a commit that referenced this pull request Dec 12, 2022
Just like #880, this refactoring is in anticipation of #873 (see [comment](#873 (comment))) for ease of review, and there are no functional changes in this PR.

Also towards #707.
mergify bot pushed a commit that referenced this pull request Dec 14, 2022
Also fixes module pluralization according to [this comment](#880 (comment)).

This is a no-op refactoring, only involving renaming/code relocations.

Towards #707.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Trigger the merge process of the Pull request. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants