Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The great install/equip switch #989

Merged
merged 6 commits into from
Jan 10, 2023
Merged

The great install/equip switch #989

merged 6 commits into from
Jan 10, 2023

Conversation

byorgey
Copy link
Member

@byorgey byorgey commented Jan 9, 2023

Closes #907.

  • Add a recipe for welder device (which provides equip/unequip)
    • Recipe = 2 copper wire + 1 copper pipe + 1 iron plate + 1 I/O cable (transitively requires furnace + 1.5 copper ore + 0.5 iron ore + 3.5 log + 1 LaTeX).
    • This recipe was suggested by @noahyor. It requires a bit of wood, a bit of copper, a bit of rubber, and a bit of iron, so a nice mid-game recipe (you need to already have a drill, but not much else).
  • Get rid of the install command
  • Update all "install" references to "equip"
  • Start base with a welder in classic mode, and in world101 and farming tutorials.
    • The base used to be able to install stuff on itself with install base, so this is just preserving the capabilities the base already had.
  • Require a welder as catalyst for making tank treads
    • No particular reason, just seemed like fun.

- Add a recipe for `welder` device (which provides `equip`/`unequip`)
  - This recipe was suggested by @noahyor.  It requires a bunch of
    copper and a bit of rubber, so a nice mid-game recipe (you
    probably need to already have a drill, but not much else)
- Get rid of the `install` command
- Update all "install" references to "equip"
@byorgey byorgey requested review from kostmo and xsebek and removed request for kostmo January 9, 2023 13:39
@byorgey
Copy link
Member Author

byorgey commented Jan 9, 2023

I know this will probably generate merge conflicts with everything, but oh well. We can definitely hold off on merging this if it's easier to merge some other things first and then I'll fix up the merge conflicts in this PR.

@byorgey
Copy link
Member Author

byorgey commented Jan 9, 2023

I particularly wanted a recipe for welder so I can actually use it in classic mode, but then I got carried away. 😄

It used to be able to `install base` with a `grabber`, so this is
just keeping things on par with the way it used to be.
It's not really necessary to solve the challenges, but makes sense to
put it there if we're going to start the base with a `welder` in
classic mode.
No particular reason, just seemed like fun.
Copy link
Member

@kostmo kostmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Let's get this in to minimize duration of any merge conflicts.

@byorgey
Copy link
Member Author

byorgey commented Jan 10, 2023

@xsebek , any thoughts?

Copy link
Member

@xsebek xsebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it - equip instead of install self is a nice improvement and does not require mirror. 👍

@byorgey byorgey added the merge me Trigger the merge process of the Pull request. label Jan 10, 2023
@mergify mergify bot merged commit f2fa93e into main Jan 10, 2023
@mergify mergify bot deleted the feature/no-install branch January 10, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Install" command
3 participants