feat: remove plugins from typescript rules

Both of them are already handled by @wpackio/base preset.
swashata · Oct 10, 2018 · c410152 · c410152
1 parent 019302d
commit c410152
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/packages/scripts/__tests__/config/__snapshots__/WebpackConfigHelper.spec.ts.snap b/packages/scripts/__tests__/config/__snapshots__/WebpackConfigHelper.spec.ts.snap
@@ -51,10 +51,6 @@ Object {
         Object {
           "loader": "babel-loader",
           "options": Object {
-            "plugins": Array [
-              "@babel/proposal-class-properties",
-              "@babel/proposal-object-rest-spread",
-            ],
             "presets": Array [
               Array [
                 "@wpackio/base",

diff --git a/packages/scripts/src/config/WebpackConfigHelper.ts b/packages/scripts/src/config/WebpackConfigHelper.ts
@@ -292,10 +292,12 @@ ${bannerConfig.copyrightText}${bannerConfig.credit ? creditNote : ''}`,
 					loader: 'babel-loader',
 					options: {
 						presets: tsPresets,
-						plugins: [
-							'@babel/proposal-class-properties',
-							'@babel/proposal-object-rest-spread',
-						],
+						// We don't need plugin-proposal-class-properties
+						// because taken care of by @wpackio/base
+						// '@babel/proposal-class-properties',
+						// We don't need object-rest-spread because it is
+						// already in stage-4 and taken care of by preset-env
+						// '@babel/proposal-object-rest-spread',
 					},
 				},
 			],