Proposed fix for swayidle forking behaviour #3382
Conversation
swayidle/main.c
Outdated
| } else { | ||
| // sd_bus_message_unref closes the file descriptor so we need |
There was a problem hiding this comment.
Style: can we replace this with goto-based error handling?
|
I don't think forking should be the default, but if you want it to be, please suggest what the flag and description should be. |
|
I think |
|
Makes sense. I've changed it to |
|
This looks good. I think the example config still needs to be updated, to use |
|
We also need to make sure this correctly locks the screen before idling. |
| } | ||
|
|
||
| // sd_bus_message_unref closes the file descriptor so we need | ||
| // to copy it beforehand | ||
| lock_fd = fcntl(lock_fd, F_DUPFD_CLOEXEC, 3); | ||
| if (lock_fd < 0) { | ||
| wlr_log(WLR_ERROR, "Failed to copy sleep lock fd: %s", | ||
| strerror(errno)); | ||
| wlr_log(WLR_ERROR, "Failed to copy sleep lock fd: %s", strerror(errno)); |
| @@ -16,6 +16,10 @@ swayidle - Idle manager for Wayland | |||
| *-d* | |||
| Enable debug output. | |||
|
|
|||
| *-w* | |||
| Wait for command to finish executing before continuing, helpful for ensuring | |||
| that a *before-sleep* command has finished before the system goes to sleep. | |||
There was a problem hiding this comment.
Maybe add a warning like "swayidle will block until the command finishes".
|
This needs to be moved to the new repo |
This should fix #3119, but I'm not sure whether it has the potential to leave zombie processes.