Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Cleanup wlr_egl #2624

Closed
3 tasks done
emersion opened this issue Jan 9, 2021 · 4 comments
Closed
3 tasks done

Cleanup wlr_egl #2624

emersion opened this issue Jan 9, 2021 · 4 comments
Labels

Comments

@emersion
Copy link
Member

emersion commented Jan 9, 2021

There are some EGL features that are no longer used by backends:

@emersion
Copy link
Member Author

emersion commented Jan 20, 2021

I think we should remove any wlr_egl usage from the examples. I'm not yet clear what's the best way to do this, since EGL initialization is quite verbose. Maybe a we need simple bool setup_wl_egl(struct wl_display *wl_display, EGLDisplay *display, EGLContext *context) helper for examples, but I'm not a fan of having examples that aren't self-contained. OTOH these aren't self-contained right now since they depend on wlr_egl.

@ammen99
Copy link
Member

ammen99 commented Jan 20, 2021

OTOH these aren't self-contained right now since they depend on wlr_egl.

What is the definition of self-contained? They surely depend on wlroots?

@emersion
Copy link
Member Author

emersion commented Jan 20, 2021

The examples using wlr_egl directly are Wayland clients, for instance toplevel-decoration. The compositor examples don't use wlr_egl directly, instead they rely on wlr_renderer and wlr_backend.

berylline added a commit to berylline/wlroots that referenced this issue Jan 21, 2021
Just another part of swaywm#2624 and swaywm#1352 that I felt needed to be done.

Breaking change:

Both EGLint *config_atrribs and egl->config no longer exist.
berylline added a commit to berylline/wlroots that referenced this issue Jan 21, 2021
Just another part of swaywm#2624 and swaywm#1352 that I felt needed to be done.

Breaking change:

Both "EGLint *config_attribs" and "egl->config" no longer exist.
berylline added a commit to berylline/wlroots that referenced this issue Jan 22, 2021
Just another part of swaywm#2624 and swaywm#1352 that I felt needed to be done.

Breaking change:

Both "EGLint *config_attribs" and "egl->config" no longer exist.
berylline added a commit to berylline/wlroots that referenced this issue Jan 22, 2021
Just another bit of EGL housekeeping done for swaywm#1352 and swaywm#2624.

Breaking changes:

"wlr_egl_context->draw_surface" and "wlr_egl_context->read_surface" have been deleted and no longer exist.
berylline added a commit to berylline/wlroots that referenced this issue Jan 26, 2021
Just another part of swaywm#2624 and swaywm#1352 that I felt needed to be done.

Breaking change:

Both "EGLint *config_attribs" and "egl->config" no longer exist.
berylline added a commit to berylline/wlroots that referenced this issue Jan 26, 2021
Just another bit of EGL housekeeping done for swaywm#1352 and swaywm#2624.

Breaking changes:

"wlr_egl_context->draw_surface" and "wlr_egl_context->read_surface" have been deleted and no longer exist.
berylline added a commit to berylline/wlroots that referenced this issue Jan 28, 2021
Just another bit of EGL housekeeping done for swaywm#1352 and swaywm#2624.

Breaking changes:

"wlr_egl_context->draw_surface" and "wlr_egl_context->read_surface" have been deleted and no longer exist.
@emersion
Copy link
Member Author

Fixed in #2666.

berylline added a commit to berylline/wlroots that referenced this issue Jan 29, 2021
Just another bit of EGL housekeeping done for swaywm#1352 and swaywm#2624.

Breaking changes:

"wlr_egl_context->draw_surface" and "wlr_egl_context->read_surface" have been deleted and no longer exist.
berylline added a commit to berylline/wlroots that referenced this issue Jan 29, 2021
Just another bit of EGL housekeeping done for swaywm#1352 and swaywm#2624.

Breaking changes:

"wlr_egl_context->draw_surface" and "wlr_egl_context->read_surface" have been deleted and no longer exist.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

2 participants