This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
backend/drm: atomic improvements #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A test commit doesn't apply the pending state. The CRTC state will be populated again if the compositor decides to perform a regular commit afterwards.
Stop using drmModeObjectSetProperty, set the property in the crtc_commit function instead.
We need to perform the FB bookkeeping on all commits, not just on page-flips.
drm_connector_set_mode already takes care of keeping this up-to-date.
When the mode, status or buffer hasn't changed, drm_connector_commit was a no-op. Because of this individual changes to the gamma LUT or adaptive sync status were ignored (if committed without a buffer). Instead, perform a commit to apply the changes.
ddevault
approved these changes
Jun 1, 2020
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
The second point fixes output state updates not applied when no modeset or page-flip is performed. For instance,
wlr_output_set_gammafollowed bywlr_output_commitwas a no-op (but shouldn't be).No Sway PR required, since
wlr_output_enable_adaptive_syncis already followed bywlr_output_commit.Closes: #2096
Breaking change:
wlr_output_enable_adaptive_syncmust now be followed bywlr_output_committo apply the change.