Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Remove unneeded includes from wlr_input_device.h #2470

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

ifreund
Copy link
Member

@ifreund ifreund commented Nov 11, 2020

This uncovered many places where we were using things without directly including them.

This allows us to avoid including tablet-unstable-v2 in many of the example compositors.

depends on #2469


Breaking change: wlr/types/wlr_input_device.h no longer pulls in all device-specific headers.

@ifreund ifreund changed the title Input device iwyu Remove unneeded includes from wlr_input_device.h Nov 11, 2020
@emersion emersion added the breaking Breaking change in public API label Nov 11, 2020
@emersion
Copy link
Member

Hmm. I know it'll be annoying for you, but could you re-order commits so that this PR can be merged before #2469? Otherwise we'll end up in an intermediate state where all compositors including wlr_input_device.h will need to generate the tablet protocol header.

@ifreund
Copy link
Member Author

ifreund commented Nov 11, 2020

Hmm. I know it'll be annoying for you, but could you re-order commits so that this PR can be merged before #2469? Otherwise we'll end up in an intermediate state where all compositors including wlr_input_device.h will need to generate the tablet protocol header.

yeah that makes sense, no worries!

This uncovered many places where we were using things without directly
including them.
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@emersion emersion merged commit e06c9e4 into swaywm:master Nov 11, 2020
@ifreund ifreund deleted the input-device-iwyu branch November 11, 2020 14:41
emersion added a commit to swaywm/sway that referenced this pull request Nov 11, 2020
@emersion emersion mentioned this pull request Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking change in public API
Development

Successfully merging this pull request may close these issues.

2 participants