Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

layer shell: rename popup iterator for consistency #2617

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

ifreund
Copy link
Member

@ifreund ifreund commented Jan 8, 2021

This iterates over the subsurfaces of popups as well, so rename it to
match wlr_xdg_surface_for_each_popup_surface().


Breaking change: wlr_layer_surface_v1_for_each_popup has been renamed to wlr_layer_surface_v1_for_each_popup_surface.

@emersion emersion added the breaking Breaking change in public API label Jan 8, 2021
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the follow-up patch!

This iterates over the subsurfaces of popups as well, so rename it to
match wlr_xdg_surface_for_each_popup_surface().
@emersion emersion merged commit 0711182 into swaywm:master Jan 12, 2021
@ifreund ifreund deleted the layer-pop-iter-rename branch January 12, 2021 10:40
@emersion emersion mentioned this pull request Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking change in public API
Development

Successfully merging this pull request may close these issues.

2 participants