Add a jsdoc parser #829
Closed
Add a jsdoc parser #829
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Jun 10, 2020
dsherret
reviewed
Jun 12, 2020
ecmascript/ast/src/jsdoc.rs
Outdated
|
|
||
| /// JsDoc tag with comments. | ||
| #[ast_node] | ||
| pub struct JsDocTagItem { |
There was a problem hiding this comment.
What about just JsDocTag to copy what's done in the TS compiler (and it's shorter 🙂)?
There was a problem hiding this comment.
Oh, I should scroll down to see the enum. Sorry! That is awesome you've implemented all those!!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems more complex than I initially thought.
Especially, I'm not sure if it's ok to change argument number based on the tag.
For example,
paramis used like@param {type} name description, so it can be parsed as an item with 3 parameters. But I don't know well about jsdoc spec.cc @dsherret @mattd3v
Closes #827.