Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/utils): Use $crate for quote_ident!() #9309

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jul 22, 2024

@kdy1 kdy1 added this to the Planned milestone Jul 22, 2024
@kdy1 kdy1 self-assigned this Jul 22, 2024
@kdy1 kdy1 requested a review from a team as a code owner July 22, 2024 02:53
Copy link

changeset-bot bot commented Jul 22, 2024

🦋 Changeset detected

Latest commit: 3a657bb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 22, 2024
@kdy1 kdy1 enabled auto-merge (squash) July 22, 2024 02:53
@kdy1 kdy1 added the automerge label Jul 22, 2024
@kdy1 kdy1 requested a review from a team as a code owner July 22, 2024 02:56
kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 22, 2024
@kdy1 kdy1 disabled auto-merge July 22, 2024 03:09
@kdy1 kdy1 enabled auto-merge July 22, 2024 03:09
@kdy1 kdy1 removed the automerge label Jul 22, 2024
Copy link

codspeed-hq bot commented Jul 22, 2024

CodSpeed Performance Report

Merging #9309 will degrade performances by 29.46%

Comparing kdy1:issue-9299 (3a657bb) with kdy1:issue-9299 (93afab0)

Summary

❌ 2 regressions
✅ 176 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark kdy1:issue-9299 kdy1:issue-9299 Change
es/full/bugs-1 534.1 µs 552 µs -3.23%
es/full/base/fixer 118.4 µs 167.8 µs -29.46%

@kdy1 kdy1 disabled auto-merge July 22, 2024 07:48
@kdy1 kdy1 merged commit bdaaf47 into swc-project:main Jul 22, 2024
153 checks passed
@kdy1 kdy1 deleted the issue-9299 branch July 22, 2024 07:48
@kdy1 kdy1 modified the milestones: Planned, v1.7.1 Jul 23, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

quote_ident inproperly references DUMMY_SP
1 participant