Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/typescript): Strip declare export in strip-only mode #9374

Merged
merged 11 commits into from
Aug 4, 2024

Conversation

magic-akari
Copy link
Member

Copy link

changeset-bot bot commented Aug 3, 2024

🦋 Changeset detected

Latest commit: f5ac306

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@magic-akari magic-akari changed the title fix(es/typescript): Strip type/declare export fix(es/typescript): Strip declare export Aug 3, 2024
@magic-akari magic-akari marked this pull request as ready for review August 3, 2024 16:39
@magic-akari magic-akari requested a review from a team as a code owner August 3, 2024 16:39
@magic-akari magic-akari changed the title fix(es/typescript): Strip declare export fix(es/typescript): Strip declare export in strip-only mode Aug 3, 2024
Copy link

codspeed-hq bot commented Aug 3, 2024

CodSpeed Performance Report

Merging #9374 will improve performances by 6.93%

Comparing magic-akari:fix/ts-strip (f5ac306) with main (4f9116f)

Summary

⚡ 2 improvements
✅ 176 untouched benchmarks

Benchmarks breakdown

Benchmark main magic-akari:fix/ts-strip Change
es/full/bugs-1 583.5 µs 545.6 µs +6.93%
es/visitor/base-perf/boxing_unboxed_clone 2.6 µs 2.5 µs +3.44%

@kdy1 kdy1 added this to the Planned milestone Aug 4, 2024
@kdy1 kdy1 merged commit c53cce4 into swc-project:main Aug 4, 2024
155 checks passed
@kdy1 kdy1 modified the milestones: Planned, 1.7.6 Aug 4, 2024
@magic-akari magic-akari deleted the fix/ts-strip branch August 7, 2024 06:12
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

The strip-type-only mode does not handle some export declare declarations
2 participants