Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): Remove unused import #9387

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Conversation

crawford
Copy link
Contributor

@crawford crawford commented Aug 6, 2024

Moving the import under the tty-emitter feature fixes the following:

warning: unused import: `IsTerminal`
  --> /home/user/swc/crates/swc_common/src/errors/emitter.rs:15:28
   |
15 |     io::{self, prelude::*, IsTerminal},
   |                            ^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

Moving the import under the tty-emitter feature fixes the following:

    warning: unused import: `IsTerminal`
      --> /home/user/swc/crates/swc_common/src/errors/emitter.rs:15:28
       |
    15 |     io::{self, prelude::*, IsTerminal},
       |                            ^^^^^^^^^^
       |
       = note: `#[warn(unused_imports)]` on by default
@crawford crawford requested a review from a team as a code owner August 6, 2024 21:05
Copy link

changeset-bot bot commented Aug 6, 2024

🦋 Changeset detected

Latest commit: 92053dc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Aug 6, 2024

CodSpeed Performance Report

Merging #9387 will degrade performances by 5.46%

Comparing crawford:compile-warning (92053dc) with main (4e854c7)

Summary

❌ 2 regressions
✅ 176 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main crawford:compile-warning Change
es/full/bugs-1 541 µs 572.2 µs -5.46%
es/full/codegen/es2015 275.5 µs 290.5 µs -5.18%

@kdy1 kdy1 added this to the Planned milestone Aug 7, 2024
@kdy1 kdy1 enabled auto-merge (squash) August 7, 2024 02:46
@kdy1 kdy1 disabled auto-merge August 7, 2024 03:15
@kdy1 kdy1 merged commit f530476 into swc-project:main Aug 7, 2024
153 checks passed
@crawford crawford deleted the compile-warning branch August 7, 2024 03:16
@kdy1 kdy1 modified the milestones: Planned, v1.7.8 Aug 7, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants