-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(visit): Introduce Pass
API and adjust visitor APIs for it
#9680
Merged
+2,496
−2,045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration guide
Please see swc-project/plugins#355 for an example upgrade.
Description:
Pass
:FnMut(&mut Program)
.Breaking Changes:
chain!
: Use a tuple instead. You can replace allchain!(
with(
with IDE feature and it will work.chain!
with 13 or more args: Use nested tuples for items after 13th element.-> impl Fold
with-> impl Pass
in general.as_folder
is nowvisit_mut_pass
and it now returnsimpl VisitMut + Pass
instead ofimpl VisitMut + Fold
.Program.apply
andProgram.mutate
can be used to applyPass
to program.fn apply(self, impl Pass) -> Self
; andfn mutate(&mut self, impl Pass)
.noop()
=>noop_pass()
. The newnoop_pass
function lives inswc_ecma_ast
and it's a real noop function.Related issue: