Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin): Bump rkyv to v0.8.8 #9730

Merged
merged 20 commits into from
Nov 11, 2024
Merged

feat(plugin): Bump rkyv to v0.8.8 #9730

merged 20 commits into from
Nov 11, 2024
+697 −363

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 11, 2024

Description:

Related issue:

@kdy1 kdy1 added this to the Planned milestone Nov 11, 2024
@kdy1 kdy1 requested a review from kwonoj November 11, 2024 02:11
@kdy1 kdy1 self-assigned this Nov 11, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 9e8c65f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kwonoj
kwonoj previously approved these changes Nov 11, 2024
View reviewed changes
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 11, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9730 will degrade performances by 4.78%

Comparing kdy1:bump-rkyv (9e8c65f) with main (e732a36)

Summary

❌ 1 regressions
✅ 193 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kdy1:bump-rkyv Change
❌ es/visitor/base-perf/boxing_boxed_clone 2.3 µs 2.4 µs -4.78%

@kdy1 kdy1 marked this pull request as ready for review November 11, 2024 03:58
@kdy1 kdy1 requested review from a team as code owners November 11, 2024 03:58
@kdy1 kdy1 requested review from a team as code owners November 11, 2024 03:58
@kdy1 kdy1 merged commit 81ac77e into swc-project:main Nov 11, 2024
150 of 151 checks passed
@kdy1 kdy1 deleted the bump-rkyv branch November 11, 2024 03:58
kdy1 added a commit to kdy1/swc that referenced this pull request Nov 11, 2024
@kdy1
Revert "feat(plugin): Bump rkyv to v0.8.8 (swc-project#9730)"
9f743fa 
This reverts commit 81ac77e.
@kdy1 kdy1 mentioned this pull request Nov 11, 2024
Merged
kdy1 added a commit that referenced this pull request Nov 11, 2024
@kdy1
refactor: Delay Wasm-plugin breaking changes (#9735)
92faf5b 
**Related issue:**

 - Reverts #9732
 - Reverts #9731
 - Reverts #9730
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

@kwonoj kwonoj kwonoj left review comments

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
Planned
Development

Successfully merging this pull request may close these issues.
2 participants
@kdy1 @kwonoj