Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Swift 5.10 #667

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Support Swift 5.10 #667

merged 3 commits into from
Mar 12, 2024

Conversation

marcprux
Copy link
Contributor

@marcprux marcprux commented Mar 6, 2024

This PR adds support for Swift 5.10: https://www.swift.org/blog/swift-5.10-released/

@grdsdev
Copy link

grdsdev commented Mar 11, 2024

Hi @marcprux this going to be very helpful, there is any thing I can do to help this getting merged?

@@ -1,6 +1,6 @@
{
"name": "setup-swift",
"version": "1.26.0",
"version": "0.1.0",
Copy link

@mflknr mflknr Mar 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at other PRs adding the latest swift version, this change doesn't seem to be necessary, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at other PRs adding the latest swift version, this change doesn't seem to be necessary, right?

TBH, I don't know. That was automatically added by "GitHub Actions (Release Drafter)".

@mflknr
Copy link

mflknr commented Mar 12, 2024

Thanks for creating the PR! I'm also waiting for 5.10 to be available.

mflknr added a commit to mflknr/swift-version-compare that referenced this pull request Mar 12, 2024
@marcprux
Copy link
Contributor Author

Hi @marcprux this going to be very helpful, there is any thing I can do to help this getting merged?

@fwal might be able to comment on the expected timeframe or any further review that is needed.

Copy link
Collaborator

@fwal fwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Getting it out now!

@fwal fwal merged commit 92f3eaf into swift-actions:main Mar 12, 2024
10 checks passed
@fwal fwal added the enhancement New feature or request label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants