sonarcloud: Use Inclusions Property #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
silverjam
approved these changes
Jul 18, 2022
|
Sonar cloud seems to be reporting "no coverage information" in the test PR? |
That's because there weren't any c/c++ code changes. It only reports the analysis for new code. I posted another PR link where there were cpp files added and it did the analysis correctly. I've added it to this PR as well. |
jungleraptor
added a commit
that referenced
this pull request
Jul 29, 2022
This reverts commit 1773f34.
krisukox
pushed a commit
that referenced
this pull request
Aug 2, 2022
Fixes code coverage builds by switching to using the sonar.inclusions property. Some of our build targets set their source directories in the include paths. Those paths are then emitted in the sonar-project.properties file here. The issue is that this can lead to files being indexed twice which the sonar-scanner treats as an error. Using the `sonar.inclusions` property and adding pattern strings avoids this issue.
krisukox
pushed a commit
that referenced
this pull request
Aug 2, 2022
Fixes code coverage builds by switching to using the sonar.inclusions property. Some of our build targets set their source directories in the include paths. Those paths are then emitted in the sonar-project.properties file here. The issue is that this can lead to files being indexed twice which the sonar-scanner treats as an error. Using the `sonar.inclusions` property and adding pattern strings avoids this issue.
This was referenced Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Code Coverage builds by switching to using the
sonar.inclusionsproperty.Some of our build targets set their source directories in the include paths. Those paths are then emitted in the
sonar-project.propertiesfile here. The issue is that this can lead to files being indexed twice which the sonar-scanner treats as an error.For example the generated file can look something like:
The inclusions property requires that we use a pattern string instead of paths, so include paths are modified with the appropriate pattern to ensure header files are included in the analysis.
See related PR for testing details: