-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compile compile command cleanup #130
Conversation
option(orion-engine_ENABLE_DOCS "" false) | ||
option(orion-engine_ENABLE_EXAMPLES "" false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these were generating warning messages
c258d2f
to
5444262
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Changes
The main bit that I've change was introduce a new python script that can be used by Helix QAC to strip off any source file which it doesn't need to analyze. I've updated the script from where it was originally implemented here so that its extensible for further develop (say something like white listing).
I've also done a few develop debt changes which have been on my plate since I'm already updating cmake: