Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile compile command cleanup #130

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Conversation

RReichert
Copy link
Contributor

@RReichert RReichert commented Aug 30, 2022

Changes

The main bit that I've change was introduce a new python script that can be used by Helix QAC to strip off any source file which it doesn't need to analyze. I've updated the script from where it was originally implemented here so that its extensible for further develop (say something like white listing).

I've also done a few develop debt changes which have been on my plate since I'm already updating cmake:

  1. I've moved a number of custom find package scripts from here to a common place
  2. I've corrected an error I've made earlier where the find_package of orion-engine throw up warning messages about missing example/test libs/documentations.

Comment on lines -15 to -16
option(orion-engine_ENABLE_DOCS "" false)
option(orion-engine_ENABLE_EXAMPLES "" false)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these were generating warning messages

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@jungleraptor jungleraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RReichert RReichert merged commit c5c4d80 into master Aug 30, 2022
@RReichert RReichert deleted the rodrigor/FE-316-helix-qac branch August 30, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants