Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nanopb version 0.4.6 [BUILD-380] #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krisukox
Copy link
Contributor

@krisukox krisukox commented Dec 5, 2022

This option is needed to use the newest nanopb with protoc older than 3.6.0.

Tested here: https://github.com/swift-nav/starling/pull/7239

@sonarcloud
Copy link

sonarcloud bot commented Dec 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@jungleraptor jungleraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, seems like this is unrelated to the issue I was talking about: https://developers.google.com/protocol-buffers/docs/news/2022-05-06#python-updates.

@silverjam
Copy link
Contributor

@isaactorz @krisukox Is this still needed?

@jungleraptor
Copy link
Contributor

@isaactorz @krisukox Is this still needed?

I think but I might not be remembering correctly: this would be necessary in order to bump nanopb in cmake. But we ended up not bumping because it also required a cmake update (which would have broken compat with one of our yocto sdks).

I think we might leave this one open since we will soon be able to break compat since we're about to be doing the builds in bazel, and are unblocked from updating nanopb on the cmake side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants